Basic git improvements

[rukins]

Thanks to @Euphrasiologist for the prompt!

I found some bugs, and here are a few improvements.

1. Fix checking if currently in git repo (Adding git branch in script doesn't work #1079)
2. Use git branch --show-current instead of git rev-parse --abbrev-ref HEAD to get current branch
3. Refactor processing current status (relying on https://git-scm.com/docs/git-status). Before, in some cases it leads to unexpected behavior. (for example, when renaming or deleting files)

[Euphrasiologist]

Thanks for updating it! Glad someone found it useful :)

[fdncred]

Looks like more than an update. Quite a bit has changed including less coloring. Is that right?

[rukins]

@fdncred, yes, just made it look more like original output of git status

[fdncred]

I agree that there are some improvements here but I'm not really a fan of changing the coloring. That's the UI part for shells so it's kind of important. Some of these changes seem to be just preferences. It would be nice to include the original authors preferences but allow others to tweak to their own preferences. Otherwise, we lose most of the work the original author put into this.

[rukins]

well, what can @Euphrasiologist say about this? Getting the original coloring back is not a problem

[Euphrasiologist]

The colours were what I personally wanted when I made it, and I agree it's nice if they are retained. But I'm happy either way 😊

[rukins]

okay, returned the branch color to original, but, as previous version doesn't consider staged and unstaged status, changes for status coloring seem reasonable. please take it into account, @fdncred

[fdncred]

okay, returned the branch color to original, but, as previous version doesn't consider staged and unstaged status, changes for status coloring seem reasonable. please take it into account, @fdncred

I guess maybe I'm missing something because I don't see the original colors in the PR. yellow_bold and blue_bold aren't anywhere in it anymore.

[rukins]

I am not sure it's a good design, but I tried to take the colors back

[fdncred]

Thanks