Escrow contract integration #1910
Open
+275
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariacarmina
changed the title
mariacarmina
requested review from
mihaisc,
alexcos20,
bogdanfazakas and
paulo-ocean
as code owners
paulo-ocean
reviewed
Mar 6, 2025
.github/workflows/ci.yml
Outdated
| - name: Run Ganache with Barge | ||
| working-directory: ${{ github.workspace }}/barge | ||
| run: | | ||
| export CONTRACTS_VERSION=escrow |
There was a problem hiding this comment.
Suggested change
| export CONTRACTS_VERSION=escrow | |
| env: | |
| CONTRACTS_VERSION: escrow |
There was a problem hiding this comment.
we should also check the conflicts
bogdanfazakas
approved these changes
Mar 12, 2025
|
Have you looked into the failing tests? |
I am looking over them now |
giurgiur99
approved these changes
Mar 26, 2025
mariacarmina
commented
Mar 26, 2025
There was a problem hiding this comment.
Thank you @giurgiur99 for fixing this PR! The escrow version container for the contracts got updated with latest modifications from 2.3.0-next.3 and implicit the functions definitions changed. I suggest to not merge this yet because we have the contract version set to escrow and maybe we do not need to merge now escrow payments into ocean.js.
mariacarmina
force-pushed
the
escrow-contract-integration
branch
from
11dd61b to
dda89da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1900 .
Changes proposed in this PR: