[core:encoding/json] When Unmarshalling, Only Match On Struct Tags If Present #4944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If a struct field contains a struct tag, we should only match on the tag.
https://godbolt.org/z/TcP3974vK
Expected
Actual
What Else I've Done
json_name_from_tag_value
, because I omitted it from a previous commit due to not understanding why it's useful (and fixed a small bug that caused, where struct tags which also contained anomitempty
would not work correctly)field_test
beside the only place it's used