Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[distributions/gateway] add gateway distribution #845

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 28, 2025

This is a new distribution that targets the use case of deploying the collector as a gateway.

In this scenario, the collector is completely passive and listens for traffic in various protocols, and exports to OTLP.

More information in the README of the distribution for review.

Fixes #834

@atoulme atoulme requested a review from a team as a code owner February 28, 2025 17:08
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't quite get why such a distribution is needed. couldn't this be handled by a user-owned config.yaml and otelcol-contrib? albeit with a bigger footprint of course with more components. Also, I think this kind of conflicts with the gateway deployment pattern described in the docs.

some other points:

  • please adjust the goreleaser configure.go file so that i generates your intended goreleaser.yaml config
  • please add the new distro to the pipeline configs under .github/workflows

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to split the goreleaser files. that is only necessary for otelcol-contrib for nightly testing purposes, but this will be handled by configure.go anyways when you change it

@jpkrohling
Copy link
Member

We talked about this during the SIG Collector, and we seem to agree that the name "gateway" does not match what we have in the manifest here. The need for this specific distribution isn't also either very clear.

atoulme and others added 3 commits March 6, 2025 08:31
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a gateway distribution
4 participants