Add tcpcheckreceiver To Contrib #865
Merged
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengchuanpeng
force-pushed
the
chengchuanp-promte_tcpcheck_receiver_to_alpha
branch
from
d1a9a8b to
f5cb21e
Compare
atoulme
reviewed
Mar 8, 2025
atoulme
changed the title
|
It's not working because it's not released yet. It was added after 0.121.0 was shipped. BTW, please add it to cmd/otelcontribcol/manifest.yaml in contrib so it's tested. |
Hi @atoulme , Thanks! |
|
yes, that's right. |
chengchuanpeng
force-pushed
the
chengchuanp-promte_tcpcheck_receiver_to_alpha
branch
from
faba014 to
d66996a
Compare
|
Added in |
|
Please fix conflicts, rebasing off main, and we can get this in. |
chengchuanpeng
force-pushed
the
chengchuanp-promte_tcpcheck_receiver_to_alpha
branch
from
74d4496 to
797110e
Compare
Co-authored-by: Antoine Toulme <antoine@toulme.name>
chengchuanpeng
force-pushed
the
chengchuanp-promte_tcpcheck_receiver_to_alpha
branch
from
797110e to
6b6c3f9
Compare
|
@atoulme done, would you helo me approve? Thanks! |
atoulme
approved these changes
Mar 18, 2025
atoulme
reviewed
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to open-telemetry/opentelemetry-collector-contrib#38443.