Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Add variable for metric name #12531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Mar 2, 2025

Description

Add variable for metric name in mdatagen, accessing via metadata.MetricsInfo.<metric-variable>.Name

Link to tracking issue

Fixes #12459

Testing

n/a

Documentation

Added

@sincejune sincejune requested review from dmitryax and a team as code owners March 2, 2025 16:23
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (40cb530) to head (dbdccda).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12531   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         479      479           
  Lines       26478    26478           
=======================================
  Hits        24239    24239           
  Misses       1765     1765           
  Partials      474      474           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sincejune sincejune force-pushed the add-metric-name-variable branch 5 times, most recently from 150cffd to 1df31c5 Compare March 27, 2025 05:24
@sincejune sincejune force-pushed the add-metric-name-variable branch from 1df31c5 to dbdccda Compare March 27, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access names from mdatagen generated metrics
2 participants