[chore] Bytes based batching for profiles #12564
Open
+196
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
requested review from
mx-psi,
dmathieu,
a team,
bogdandrutu and
dmitryax
as code owners
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12564 +/- ##
==========================================
- Coverage 91.54% 91.43% -0.11%
==========================================
Files 479 480 +1
Lines 26478 26549 +71
==========================================
+ Hits 24239 24276 +37
- Misses 1765 1798 +33
- Partials 474 475 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfc-gh-sili
reviewed
Mar 14, 2025
sfc-gh-sili
reviewed
Mar 14, 2025
iblancasa
force-pushed
the
profiles-sizer
branch
2 times, most recently
from
8c64251 to
ddedc5b
Compare
iblancasa
force-pushed
the
profiles-sizer
branch
from
ddedc5b to
e43b829
Compare
|
Fixed conflicts. Can you review? @dmitryax @bogdandrutu |
iblancasa
force-pushed
the
profiles-sizer
branch
2 times, most recently
from
2c4b214 to
2d45881
Compare
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
force-pushed
the
profiles-sizer
branch
from
2d45881 to
6979d6f
Compare
iblancasa
changed the title
sfc-gh-sili
reviewed
Mar 28, 2025
| protoDeltaSizer | ||
| } | ||
|
|
||
| var _ ProfilesSizer = (*ProfilesBytesSizer)(nil) |
There was a problem hiding this comment.
What is this anonymous variable for?
sfc-gh-sili
reviewed
Mar 28, 2025
| @@ -135,7 +140,7 @@ func TestMergeSplitProfiles(t *testing.T) { | |||
| func TestExtractProfiles(t *testing.T) { | |||
| for i := 0; i < 10; i++ { | |||
| ld := testdata.GenerateProfiles(10) | |||
| extractedProfiles := extractProfiles(ld, i) | |||
| extractedProfiles, _ := extractProfiles(ld, i, &sizer.ProfilesCountSizer{}) | |||
There was a problem hiding this comment.
Can you add some unit test for the bytes based batching?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements serialized bytes based batching for metrics.
Link to tracking issue
#3262
Continuation of #12299 made by @sfc-gh-sili.
Related PRs: