exporters: prometheus: add expontential (native) histogram support #6421
+134
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
|
Signed CLA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 283 283
Lines 24910 24942 +32
=======================================
+ Hits 20385 20405 +20
- Misses 4120 4129 +9
- Partials 405 408 +3 🚀 New features to boost your workflow:
|
dmathieu
reviewed
Mar 10, 2025
GiedriusS
force-pushed
the
nh_support_exporter
branch
from
4a2699c to
1765699
Compare
|
Rebased PR on top of origin/main after #6433. |
|
Do we need a documentation update on how to use this? If there is any explicit setup required. |
Should we document how to set up a view like this? |
|
We could possibly update the prometheus example to showcase this. That examples folder is linked on the opentelemetry.io website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost closes 5777.
Adding native (exponential) histogram support to the Prometheus exporter. I tested it with a toy program, and the result looks good. I added a unit test.