Adding vtkhdf option to write vtk data #3252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
reviewed
Jan 9, 2025
mwestphal
reviewed
Jan 9, 2025
jon-proximafusion
changed the title
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
shimwell
reviewed
Jan 9, 2025
|
Looks really nice @shimwell! It will be a great option to have. I'll review as soon as I am able. |
|
@pshriwise just to mention we are working on adding for more VTK based file formats in addition to this VTKHDF. We are also looking at adding VTU. So we are building on this branch with another feature. We won't make a PR for the VTU work till this VTKHDF PR has been merged or rejected, but I just wanted to let you know so you can take that into account when reviewing. |
rherrero-pf
reviewed
Feb 4, 2025
tests/regression_tests/unstructured_mesh/test_mesh_dagmc_tets.vtk
Outdated
Show resolved
Hide resolved
Co-authored-by: rherrero-pf <156206440+rherrero-pf@users.noreply.github.com>
|
Related PR to enable export flexibility #3290 |
This comment was marked as resolved.
This comment was marked as resolved.
|
@pshriwise I've solved the merge conflicts and i think this one is ready for review when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #3113 it would be great to have a method of writing VTKHDF files for mesh tally data.
This PR allows users to write .hdf file VTKHDF compatible files with the existing
UnstructuredMesh.write_data_to_vtk()method. This has a few advantages over the legacy vtk files we currently write.It would be particularly useful for those of us who can't make use of the vtk package in their environment. We have this issue at the moment and can't import cadquery along with openmc due to slightly different vtk packages. It is super useful that vtk is an optional dependency in openmc and not mandated. This use of h5py lets us avoid using the vtk package while still being able to write VTKHDF files
For interested people the VTKHDF roadmap is here, the ability to read these files (ending with hdf) was introduced in Paraview 5.13.0 release notes.
All credit goes to the Kitware developers and particularly @mwestphal who introduced me to this feature
Fixes # (issue)
partly addresses #3113
Checklist