Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ramp from temple of the moon goddess #3469

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

XmasGame
Copy link

When you use the ramp at Position(33613, 32759, 9), you up as simple ramp to the north direction:
image

And in global tibia when you go up the same ramp it ends in the Position(33614, 32759, 8)
image

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@Mirino97
Copy link

Hi! Sorry if this is a dumb question, but was your intention to delete the monster files in this PR?
I'm failing to understand how it's related to the ramp bug.

@XmasGame
Copy link
Author

Hi! Sorry if this is a dumb question, but was your intention to delete the monster files in this PR? I'm failing to understand how it's related to the ramp bug.

The monsters that were removed were a mistake I made when posting. It's not really relevant.
My mistake, hehe. Don't mind it. It's just the new script that was added to the "Marapur" folder.

@Mirino97
Copy link

I have tested this locally.

After manually adding the .lua extension to the script file, everything works correctly.
I cannot attest to the quality of the code itself as I'm not an experienced programmer, but to my beginner eyes, everything looks ok!

2025-03-27.21-23-00.mp4

@XmasGame
Copy link
Author

I have tested this locally.

After manually adding the .lua extension to the script file, everything works correctly. I cannot attest to the quality of the code itself as I'm not an experienced programmer, but to my beginner eyes, everything looks ok!

2025-03-27.21-23-00.mp4

Yes, that's because the ramp item is a changefloor -> up, which makes the player first go up a floor and then the script 'transports' him to the place he should be...

Thanks for test it

Copy link
Contributor

@murilo09 murilo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a map problem, do you have an example from how it it on tibia global?

@Mirino97
Copy link

I can confirm Global's implementation is to teleport the player to the side, just like XmasGame has done:

https://youtu.be/x0KT_csZ3vs?si=k4KT24A1MYd2Q6BW&t=103

@XmasGame
Copy link
Author

Maybe a map problem, do you have an example from how it it on tibia global?

Mirino97 just posted a link from YouTube
https://youtu.be/x0KT_csZ3vs?si=k4KT24A1MYd2Q6BW&t=103
tibia global hunt in temple of moon godness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants