Skip to content

fix: buyhouse command #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gabrielgg98
Copy link

Description

Corrigindo bug referente ao comando !buyhouse, só estava funcionando para o GOD mesmo com a opção "toggleCyclopediaHouseAuction = false"

Behaviour

Actual

Ao usar !buyhouse por players, o comando não era reconhecido. Mesmo com o "toggleCyclopediaHouseAuction = false". Apenas com o GOD funcionava.

Expected

Agora o !buyhouse funciona de acordo com a config.lua normalmente.

Type of change

  • [ X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Testado localmente.

Test Configuration:

  • Server Version: 3.1.2
  • Client: 13.4
  • Operating System: Windows

Checklist

  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have performed a self-review of my own code
  • [ X ] I checked the PR checks reports
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ X ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

Copy link

@Mirino97 Mirino97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testado localmente e funcinando!

Copy link

@b-bgomes b-bgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcionando normalmente agora.
Como foi descrito no PR antes com a opção da cyclopedia desligada o player não conseguia comprar a casa.
Agora com o if no talkaction da pasta god, o player consegue se a opção da cyclopledia no config.lua estiver false.

@murilo09 murilo09 changed the title fix buyhouse command fix: buyhouse command Mar 29, 2025
@murilo09 murilo09 self-requested a review March 29, 2025 23:12
Copy link
Contributor

@murilo09 murilo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this command from GOD please

@gabrielgg98 gabrielgg98 requested a review from murilo09 March 30, 2025 02:38
Copy link
Author

@gabrielgg98 gabrielgg98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script buy_house.lua deleted from "talkactions/god". PR is done.

@gabrielgg98 gabrielgg98 closed this Apr 2, 2025
@gabrielgg98 gabrielgg98 reopened this Apr 2, 2025
Copy link

sonarqubecloud bot commented Apr 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants