Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dead code: dbuf_loan_arcbuf #17119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Mar 5, 2025

It's been dead ever since 5fa356e

Sponsored by: ConnectWise
Signed-off-by: Alan Somers asomers@gmail.com

Motivation and Context

General code maintenance

Description

Delete an unused function definition

How Has This Been Tested?

Haven't tested it at all. Relying on CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

It's been dead ever since 5fa356e

Sponsored by:	ConnectWise
Signed-off-by:	Alan Somers <asomers@gmail.com>
@amotin
Copy link
Member

amotin commented Mar 5, 2025

Not that I have objections, but after this arc_loan_inuse_buf() becomes unused, etc. I'd say would be good to investigate which of this code is still alive and could be possibly reused one day, and which may be long broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants