-
Notifications
You must be signed in to change notification settings - Fork 51
feat: add support for Ory Hydra consent screens #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TODO:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 42.43% 48.68% +6.25%
==========================================
Files 136 146 +10
Lines 2008 2366 +358
Branches 288 363 +75
==========================================
+ Hits 852 1152 +300
- Misses 1149 1200 +51
- Partials 7 14 +7
🚀 New features to boost your workflow:
|
016f788
to
6e9dfc4
Compare
83080c1
to
f3c2f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM! I left a few comments about translations and some minor nit picking and once that is resolved we can merge it
Related Issue or Design Document
Checklist
Further comments |
Adds support for the Ory Hydra consent screen.