Skip to content

feat: add support for Ory Hydra consent screens #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 1, 2025
Merged

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Mar 3, 2025

Adds support for the Ory Hydra consent screen.

@jonas-jonas jonas-jonas self-assigned this Mar 3, 2025
@jonas-jonas
Copy link
Member Author

jonas-jonas commented Mar 12, 2025

TODO:

  • Stories via snapshots
  • some unit tests would be good
  • e2e tests
  • figure out how to present scopes for which we don't have descriptions

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 47.41379% with 61 lines in your changes missing coverage. Please review.

Project coverage is 48.68%. Comparing base (f3fad4d) to head (312f6e3).
Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   42.43%   48.68%   +6.25%     
==========================================
  Files         136      146      +10     
  Lines        2008     2366     +358     
  Branches      288      363      +75     
==========================================
+ Hits          852     1152     +300     
- Misses       1149     1200      +51     
- Partials        7       14       +7     
Components Coverage Δ
@ory/elements-react 45.49% <36.81%> (+8.70%) ⬆️
@ory/nextjs 64.33% <ø> (-1.65%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcaillaudm pcaillaudm force-pushed the jonas-jonas/consent branch from 016f788 to 6e9dfc4 Compare March 24, 2025 14:37
@pcaillaudm pcaillaudm marked this pull request as ready for review March 24, 2025 14:44
@pcaillaudm pcaillaudm force-pushed the jonas-jonas/consent branch from 83080c1 to f3c2f07 Compare March 27, 2025 13:53
@pcaillaudm pcaillaudm self-assigned this Mar 27, 2025
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! I left a few comments about translations and some minor nit picking and once that is resolved we can merge it

@aeneasr
Copy link
Member

aeneasr commented Apr 1, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

image

@pcaillaudm pcaillaudm merged commit 95ad0fb into main Apr 1, 2025
14 checks passed
@pcaillaudm pcaillaudm deleted the jonas-jonas/consent branch April 1, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants