This repository was archived by the owner on Apr 19, 2025. It is now read-only.
fix(server/inventory): CanCarryItem returning false where an item should be able stack. #1907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1906
Essentially when an inventory is full of items, when you try and check if you can add a stackable item that is in the inventory using
CanCarryItem
, it returns false. It seemed to stem from the strict metadata check.When the metadata value is nil in CanCarryItem, the metadata table created is
{ type = nil }
. Lua treats that new table as a hashmap even though it's really just an empty table (at leasttable.type
looks at the table like that), and it seems to break the strict metadata check.