GNOME 45 support #150
Merged
GNOME 45 support #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
"Lang" is deprecated and shouldn't be used any more. This breaks compatibility with GNOME shell < 3.32. Signed-off-by: Martin Wilck <mwilck@suse.com>
We can't support older GNOME shell versions any more, anyway. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
The "mainloop" import exists no more. GLib functions can be called directly for creating and handling timeout events. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extension-js Signed-off-by: Martin Wilck <mwilck@suse.com>
GNOME 45 support is exclusive with all prior GNOME shell versions. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Closed
13 tasks
Closed
hobbypunk90
suggested changes
Mar 27, 2024
Works great - thank you! (I also changed "45" to "46" in metadata.json.) |
Use `add_child` instead of the removed (not deprecated) `add_actor` https://gjs.guide/extensions/upgrading/gnome-shell-46.html#clutter-container - Compatibility with GNOME 45 tested on Fedora 39 - Compatibility with GNOME 46 tested on Fedora 40 beta. Resolves #157 Signed-off-by: Michel Lind <salimma@fedoraproject.org>
Add support for GNOME 46
|
As GNOME 46 is out now, and GNOME 45 has been out for 6 months, I am merging this into the master branch now, finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GNOME shell 45 support to Argos, at the cost of removing support for all previous GNOME versions.
The first patches (up to 5ae5a97) are actually cleanups for the current ("GNOME shell up to 44") code which make applying the GNOME 45 changes more straighforward.
Fixes #149.