-
Notifications
You must be signed in to change notification settings - Fork 306
[WIP] Replace HK2/Types/Parser/Scanner with Jandex and cache in the domain #7165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lprimak
wants to merge
44
commits into
payara:main
Choose a base branch
from
flowlogix:jandex-deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleus/common/internal-api/src/main/java/org/glassfish/internal/deployment/JandexIndexer.java
Show resolved
Hide resolved
This was referenced Jan 23, 2025
543e287
to
75c6091
Compare
bdfa809
to
aa27959
Compare
7ed90c6
to
c4b0809
Compare
c4b0809
to
e9093da
Compare
91a9a95
to
d11a3f6
Compare
This was referenced Feb 26, 2025
…ssue" This reverts commit 52b79c5.
- delay Jandex cache writing until after deployment
…combined EAR CDI deployment
…d on the actual type of the injection point desired
…tartup" This reverts commit 4e2d97d.
…ith an existing ClassLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy performance improvements
This is an experiment (for now)
This PR achieves at least 2X improvement when dependencies are not cached, which is a worst-case scenario.
I have seen as much as 5X performance improvement on a warmed-up JVM with dependencies cached,
with many dependencies.
Feedback is appreciated
Thank you.
Fixes #7079
issue-reproducers/cdi-unknownbda
reproducerStructuredDeploymentTracing tracing = StructuredDeploymentTracing.load(context);
tracing.startSpan(DeploymentTracing.AppStage.CLASS_SCANNING, source.getName());
for each sourceDeploymentProperties.SKIP_SCAN_EXTERNAL_LIB
supportGenericAnnotationDetector
to see if it's getting used anywhere / use Jandex for it