Feature/199 PutUserInfo #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dviry
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
petrsvihlik
previously approved these changes
Mar 9, 2025
dviry
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 37.90% 40.70% +2.79%
==========================================
Files 54 56 +2
Lines 1348 1415 +67
Branches 149 154 +5
==========================================
+ Hits 511 576 +65
+ Misses 796 792 -4
- Partials 41 47 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dviry
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
dviry
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
petrsvihlik
approved these changes
Mar 10, 2025
petrsvihlik
added a commit
that referenced
this pull request
Mar 12, 2025
* fix sln sample projects references * #199 add PutUserInfo endpoint and enable respective hostCapability * fix unit test * add some unit tests * split ProcessLock() to reduce complexity * #195 add DeleteFile and refactor IWopiWritableStorageProvider to DeleteWopiResource() and RenameWopiResource() * Feature/199 PutUserInfo (#200) * fix sln sample projects references * #199 add PutUserInfo endpoint and enable respective hostCapability * fix unit test * add some unit tests * split ProcessLock() to reduce complexity --------- Co-authored-by: Leon Segal <leon.segal@hs-soft.com> * Update README.md * #195 add DeleteFile and refactor IWopiWritableStorageProvider to DeleteWopiResource() and RenameWopiResource() * fix PutFile logic * add InternalServerErrorResult * refactor GetWopiFiles/Containers to return AsyncEnumerables * extract common Name and Identifier to IWopiResource * add IWopiStorageProvider.GetWopiResourceByName() * consolidate to CreateWopiChildResource(), add CheckValidName() and GetSuggestName() as helpers * #195 add FilesController.PutRelativeFile * #195 fix FileNameLongerThan512Chars * #195 pass HostEditUrl and HostViewUrl from CheckFileInfo * #195 fix UTF-7 handling --------- Co-authored-by: Leon Segal <leon.segal@hs-soft.com> Co-authored-by: Petr Švihlík <rocky.intel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199 by implementing FilesController.PutUserInfo() action, returning the CheckFileInfo.UserInfo property with the stored userInfo and enabling the HostCapabilities.SupportsUserInfo.