Skip to content

Add codec ffmpeg #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add codec ffmpeg #621

wants to merge 1 commit into from

Conversation

3DRX
Copy link
Member

@3DRX 3DRX commented Apr 8, 2025

This is a PR for adding ffmpeg based video encoders.

  • Documentation, since ffmpeg library is introduced as dependency, building requires CGO so it's not a working-out-of-the-box experience.
  • Update CI pipeline, or it will failed for not founding ffmpeg library. We add go-astiav as a dependency in pkg/codec/ffmpeg/go.mod to avoid breaking CI and other user's build. When using github.com/pion/mediadevices/pkg/codec/ffmpeg, it's a requirement for users to provide their own ffmpeg library as described here.

@3DRX 3DRX force-pushed the add_codec_ffmpeg branch from 25768e5 to 94cbd6b Compare April 10, 2025 13:54
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.51%. Comparing base (20e8c50) to head (39bc14a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   44.51%   44.51%           
=======================================
  Files          80       80           
  Lines        5556     5556           
=======================================
  Hits         2473     2473           
  Misses       2913     2913           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3DRX 3DRX marked this pull request as ready for review April 10, 2025 13:56
@3DRX 3DRX force-pushed the add_codec_ffmpeg branch 4 times, most recently from 35848ce to d1c609a Compare April 10, 2025 16:23
@3DRX 3DRX requested review from Sean-Der and JoeTurki April 10, 2025 16:34
@3DRX 3DRX force-pushed the add_codec_ffmpeg branch from d1c609a to f4a451c Compare April 11, 2025 04:27
@3DRX 3DRX force-pushed the add_codec_ffmpeg branch from f4a451c to 39bc14a Compare April 13, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant