Add Advertising / Reading ICE trickle support #3097
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Figured I'd try my hand at dealing with this. I'll be honest and say I don't FULLY understand what this is for, since pion already supports trickle ICE, but since this IS part of the spec, might as well.
This is nowhere near done (I will also have to do a pull request to the SDP repo to finish the feature), but I do have some questions
the "a=ice-options:tickle" seem to be related to ice2? Whatever that is (see https://datatracker.ietf.org/doc/html/rfc9725#section-4.3.3)
Does that mean I have to tack on ice2 to the attribute?Resolved, it just tells us what version of ICE we are using Advertising / Reading ICE trickle support #2898 (comment)how exactly would i add the attribute? I guess I just add a constant here and be done with it https://github.com/pion/sdp/blob/c395deb80b693c4a4f5b28d1ce435f27fa2bc40e/jsep.go#L14
Reference issue
Fixes #2898