Skip to content

Add Advertising / Reading ICE trickle support #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ValorZard
Copy link

@ValorZard ValorZard commented Apr 13, 2025

Description

Figured I'd try my hand at dealing with this. I'll be honest and say I don't FULLY understand what this is for, since pion already supports trickle ICE, but since this IS part of the spec, might as well.

This is nowhere near done (I will also have to do a pull request to the SDP repo to finish the feature), but I do have some questions

Reference issue

Fixes #2898

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (c79463d) to head (536db69).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c79463d) and HEAD (536db69). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c79463d) HEAD (536db69)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3097       +/-   ##
===========================================
- Coverage   78.71%   63.84%   -14.88%     
===========================================
  Files          91       69       -22     
  Lines       11347     4251     -7096     
===========================================
- Hits         8932     2714     -6218     
+ Misses       1928     1404      -524     
+ Partials      487      133      -354     
Flag Coverage Δ
go ?
wasm 63.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ValorZard
Copy link
Author

I think this is ready to be reviewed, pretty sure this is the api changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Advertising / Reading ICE trickle support
2 participants