Skip to content

fix: add extension for lodash imports in funnel package #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

melkstam
Copy link
Contributor

@melkstam melkstam commented Apr 22, 2025

This fixes what I think is a simple merge miss.

#2704 added these two imports, but #2712 did at the same time add .js to all lodash imports.

This causes a build error in one of my projects.

Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 8:37pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d76f75:

Sandbox Source
nivo Configuration

@plouc plouc merged commit 0b2a12c into plouc:master Apr 22, 2025
5 checks passed
@plouc
Copy link
Owner

plouc commented Apr 22, 2025

@melkstam, good catch! Thank you!

@melkstam melkstam deleted the fix-lodash-import branch April 23, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants