Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Pointer to Interaction Model Engine on Shutdown #37958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reset Pointer to Interaction Model Engine on Shutdown #37958

wants to merge 1 commit into from

Conversation

hawkinsw
Copy link

Reset the member variable pointer to the Interaction Model Engine when the Checkin Handler is shutdown.

Testing

WIP

@hawkinsw
Reset Pointer to Interaction Model Engine on Shutdown
6fa559b 
Reset the member variable pointer to the Interaction Model Engine when
the Checkin Handler is shutdown.
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added app icd Intermittently Connected Devices labels Mar 11, 2025
@hawkinsw
Copy link
Author

@witowsg-amazon Hello! I am sorry for such a minor suggested change. I am not even 100% sure that it should be included. But, I thought I would offer it anyways. If it is something that needs to be included, I am more than happy to add unit tests in the appropriate spot. Thank you for all the work that you are doing on this SDK!

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

PR #37958: Size comparison from b56134c to 6fa559b

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section b56134c 6fa559b change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098268 1098268 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 653246 653246 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830518 830518 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1062916 1062916 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 893758 893758 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976654 976654 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818232 818232 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827152 827152 0 0.0
RAM 125392 125392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774012 774012 0 0.0
RAM 113764 113764 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758288 758288 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541806 541806 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 575906 575906 0 0.0
RAM 205400 205400 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 659925 659925 0 0.0
RAM 75436 75436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 679785 679785 0 0.0
RAM 78076 78076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 679785 679785 0 0.0
RAM 78076 78076 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 636717 636717 0 0.0
RAM 70504 70504 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620173 620173 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639809 639809 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639809 639809 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639669 639669 0 0.0
RAM 74684 74684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659385 659385 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659385 659385 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616009 616009 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635869 635869 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635869 635869 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 940744 940744 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 734408 734408 0 0.0
RAM 234856 234856 0 0.0
window-app BRD4187C FLASH 1033296 1033288 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 98728 98728 0 0.0
FLASH 1594350 1594350 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117524 117524 0 0.0
FLASH 1560958 1560958 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2659171 2659171 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5980720 5980720 0 0.0
RAM 516696 516696 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5317164 5317164 0 0.0
RAM 222680 222680 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4630952 4630952 0 0.0
RAM 201000 201000 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4681036 4681036 0 0.0
RAM 195808 195808 0 0.0
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11345553 11345553 0 0.0
RAM 597312 597312 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13365611 13365611 0 0.0
RAM 605952 605952 0 0.0
chip-tool-ipv6only arm64 unknown 22120 22120 0 0.0
FLASH 11551400 11551400 0 0.0
RAM 658632 658632 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11636803 11636803 0 0.0
RAM 605736 605736 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4461940 4461940 0 0.0
RAM 188200 188200 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5579029 5579029 0 0.0
RAM 471968 471968 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5525249 5525249 0 0.0
RAM 205168 205168 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4697728 4697728 0 0.0
RAM 192360 192360 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4319874 4319874 0 0.0
RAM 181016 181016 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4450258 4450258 0 0.0
RAM 185504 185504 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2957484 2957484 0 0.0
RAM 145456 145456 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4146808 4146808 0 0.0
RAM 229848 229848 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5917909 5917909 0 0.0
RAM 595400 595400 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11538125 11538125 0 0.0
RAM 721744 721744 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915768 915768 0 0.0
RAM 142881 142881 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 908836 908836 0 0.0
RAM 125221 125221 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852600 852600 0 0.0
RAM 141243 141243 0 0.0
nxp contact k32w0+release FLASH 588336 588336 0 0.0
RAM 71004 71004 0 0.0
mcxw71+release FLASH 603560 603560 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 614132 614132 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 687648 687648 0 0.0
RAM 72056 72056 0 0.0
lock mcxw71+release FLASH 752424 752424 0 0.0
RAM 67556 67556 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661316 1661316 0 0.0
RAM 212344 212344 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565612 1565612 0 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1442348 1442348 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471244 1471244 0 0.0
RAM 224984 224984 0 0.0
qpg lighting-app qpg6105+debug FLASH 664844 664844 0 0.0
RAM 105180 105180 0 0.0
lock-app qpg6105+debug FLASH 623304 623304 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 460920 460920 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 665734 665734 0 0.0
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623316 623316 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762090 762090 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 755198 755198 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 682248 682248 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710806 710806 0 0.0
RAM 73400 73400 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 703356 703356 0 0.0
RAM 37664 37664 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602926 602926 0 0.0
RAM 138640 138640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 790214 790214 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1783240 1783240 0 0.0
RAM 94168 94168 0 0.0
chip-tool-ubsan arm unknown 11560 11560 0 0.0
FLASH 1909284 1909284 0 0.0
RAM 8355068 8355068 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

Assignees
No one assigned
Labels
app icd Intermittently Connected Devices review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkinsw @CLAassistant @bzbarsky-apple