Add support for money and new electrical data types #37980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37980: Size comparison from c0e580c to 929c0b0 Full report (5 builds for cc32xx, stm32, tizen)
|
jamesharrow
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Have tested with these changes and my test PR #37902 (not that that will be raised for review) but gives confidence in these changes.
jamesharrow
added a commit
to jamesharrow/connectedhomeip
that referenced
this pull request
Mar 12, 2025
jamesharrow
added a commit
to jamesharrow/connectedhomeip
that referenced
this pull request
Mar 12, 2025
|
PR #37980: Size comparison from c0e580c to 88881f6 Full report (3 builds for cc32xx, stm32)
|
|
PR #37980: Size comparison from c0e580c to d86ebe8 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37980: Size comparison from 5adee57 to 1a72da1 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Mar 14, 2025
| @@ -104,8 +104,14 @@ def NormalizeDataType(t: str) -> str: | |||
|
|
|||
| # Handle odd casing and naming | |||
| _CASE_RENAMES_MAPPING = { | |||
| "amperage_mA": "amperage_ma", | |||
There was a problem hiding this comment.
So are we not using the spec casing for these types here because of ZAP limitations? Is there something tracking that?
| MOCK_ATTRIBUTE_CONFIG_NULLABLE(ZCL_AMPERAGE_MA_ATTRIBUTE_TYPE), | ||
| MOCK_ATTRIBUTE_CONFIG_NULLABLE(ZCL_VOLTAGE_MV_ATTRIBUTE_TYPE), | ||
| MOCK_ATTRIBUTE_CONFIG_NULLABLE(ZCL_ENERGY_MWH_ATTRIBUTE_TYPE), | ||
| MOCK_ATTRIBUTE_CONFIG_NULLABLE(ZCL_ENERGY_MVAH_ATTRIBUTE_TYPE), | ||
| MOCK_ATTRIBUTE_CONFIG_NULLABLE(ZCL_ENERGY_MVARH_ATTRIBUTE_TYPE), |
There was a problem hiding this comment.
Does this need a "money" case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new atomic types going with Matter 1.5:
power_mVA
power_mVAR
energy_mVAh
energy_mVARh
money
Testing
Ran build.