[Scenes] LastConfiguredBy Removal #38003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
force-pushed
the
feature/last-configured-by-removal
branch
from
7d90801 to
ff8ca4c
Compare
bzbarsky-apple
approved these changes
Mar 14, 2025
| <arg name="TransitionTime" type="int32u"/> | ||
| <arg name="SceneName" type="char_string"/> | ||
| <arg name="ExtensionFieldSets" type="ExtensionFieldSet" array="true"/> | ||
| <description>It is not mandatory for an extension field set to be included in the command for every cluster on that endpoint that has a defined extension field set.</description> |
There was a problem hiding this comment.
This is ... a pretty terrible description. Followup: get this fixed.
Comment on lines
+88
to
+89
| <attribute side="server" code="0x0000" name="SceneTableSize" define="SCENE_TABLE_SIZE" type="int16u" default="16">SceneTableSize</attribute> | ||
| <attribute side="server" code="0x0001" name="FabricSceneInfo" define="FABRIC_SCENE_INFO" type="array" entryType="SceneInfoStruct">FabricSceneInfo</attribute> |
There was a problem hiding this comment.
This seems to be using an old version of alchemy, so it's adding the name of the attribute in multiple places?
There was a problem hiding this comment.
I pull the latest version and the generated output remains the same, when you say:
adding the name of the attribute in multiple places
You mean that name="SceneTableSize" should not be in the xml?
lpbeliveau-silabs
force-pushed
the
feature/last-configured-by-removal
branch
2 times, most recently
from
10d5039 to
9d5de2e
Compare
|
PR #38003: Size comparison from 1675464 to 9d5de2e Full report (3 builds for cc32xx, stm32)
|
lpbeliveau-silabs
force-pushed
the
feature/last-configured-by-removal
branch
2 times, most recently
from
2de31ea to
eea7784
Compare
lpbeliveau-silabs
force-pushed
the
feature/last-configured-by-removal
branch
from
eea7784 to
6d56afe
Compare
|
PR #38003: Size comparison from 1675464 to 6d56afe Full report (3 builds for cc32xx, stm32)
|
|
PR #38003: Size comparison from 1675464 to 2744cd4 Full report (5 builds for cc32xx, stm32, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of LastConfiguredAttribute in code and Test to follow spec changes in https://github.com/CHIP-Specifications/chip-test-plans/pull/4991
Testing
Locally build and run Scenes Yaml tests.