Abort render-pipeline when we get a null catalog URL
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abort `render-pipeline` script when Lieutenant API returns no catalog URL for a cluster. This makes the failure mode more obvious than unexpected failing compile jobs for some clusters (usually with an error like "fatal: unable to access '<catalog repo>': The requested URL returned error: 403".
bastjan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort
render-pipelinescript when Lieutenant API returns no catalog URL for a cluster. This makes the failure mode more obvious than unexpected failing compile jobs for some clusters (usually with an error like "fatal: unable to access 'catalog repo': The requested URL returned error: 403".Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
in the correct changelog section:
bug,enhancement,documentation,change,breaking,dependency,internal