Skip to content

Special post-processing for rivers #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Special post-processing for rivers #425

wants to merge 2 commits into from

Conversation

wipfli
Copy link
Collaborator

@wipfli wipfli commented Mar 17, 2025

After merging the water matcher pull request, we found that some rivers got dropped because we increased the minimum polygon area to 10 pixels2.

Here we apply special casing for rivers in the post-processing step, such that river polygons are kept down to 1 pixel2 area.

However, not that sometimes OSM features don't tag stuff as rivers. So in Bogota for example there will still be feature dropping because the merging fails (kind_detail=river is absent). Example: https://www.openstreetmap.org/relation/12757766#map=11/5.6744/-74.4660

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@bdon
Copy link
Member

bdon commented Mar 21, 2025

I think #428 can solve this too

@wipfli
Copy link
Collaborator Author

wipfli commented Mar 24, 2025

Closing in favor of #428

@wipfli wipfli closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants