Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure updates for Microsoft Corporate Domains #1891

Merged
merged 3 commits into from
Feb 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions public_suffix_list.dat
Original file line number Diff line number Diff line change
Expand Up @@ -14077,7 +14077,13 @@ co.pl

// Microsoft Corporation : http://microsoft.com
// Submitted by Public Suffix List Admin <msftpsladmin@microsoft.com>
// Managed by Corporate Domains
// Microsoft Azure : https://home.azure
cloudapp.azure.com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since domains issued on cloudapp.azure.com are in the format <label>.<region>.cloudapp.azure.com shouldn't the rule be *.cloudapp.azure.com so that domains issued to vms in the same region are treated as different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for calling that out, I have updated it to the wildcard

*.azurecontainer.io
azure-api.net
azureedge.net
azurefd.net
azurewebsites.net
azure-mobile.net
cloudapp.net
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwa001 please drop cloudapp.net to just above trafficmanager.net

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated order as requested

Expand All @@ -14094,6 +14100,9 @@ eastasia.azurestaticapps.net
eastus2.azurestaticapps.net
westeurope.azurestaticapps.net
westus2.azurestaticapps.net
trafficmanager.net
blob.core.windows.net
servicebus.windows.net

// minion.systems : http://minion.systems
// Submitted by Robert Böttinger <r@minion.systems>
Expand Down