Metrics of implicit, explicit and missed parachain votes #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceseer
reviewed
Feb 21, 2025
Comment on lines
3390
to
3395
| struct CleanupGuard { | ||
| std::function<void()> cleanup; | ||
| ~CleanupGuard() { | ||
| cleanup(); | ||
| } | ||
| } cleanup_guard{[this, &block_hash] { |
There was a problem hiding this comment.
auto guard = std::unique_ptr<void, std::function<void(void*)>>(
(void*)1,
[&](void*) {
state_by_relay_parent_to_check_.erase(block_hash);
}
);
Comment on lines
3433
to
3435
| const auto availability_cores_res = | ||
| parachain_host_->availability_cores(block_hash); | ||
| if (not availability_cores_res) { |
ErakhtinB
force-pushed
the
feature/missing_votes_metric
branch
from
5c57799 to
44d89fb
Compare
kamilsa
force-pushed
the
feature/missing_votes_metric
branch
from
a1ab879 to
f4e0eee
Compare
ErakhtinB
force-pushed
the
feature/missing_votes_metric
branch
from
f4e0eee to
6ea2a13
Compare
kamilsa
reviewed
Mar 21, 2025
| } | ||
| our_current_state_.state_by_relay_parent.erase(it); | ||
| } | ||
| std::cout << fmt::format("---> PRUNED {}\n", removed); |
iceseer
reviewed
Mar 25, 2025
Comment on lines
3345
to
3355
| if (not previous_last_finalized_block) { | ||
| previous_last_finalized_block = last_finalized_block; | ||
| if (last_finalized_block == 0) { | ||
| return; | ||
| } | ||
| } else { | ||
| current_block_number = previous_last_finalized_block.value() + 1; | ||
| } | ||
| for (auto i = current_block_number - 1; i < last_finalized_block; ++i) { | ||
| const auto block_hash_res = block_tree_->getBlockHash(i); | ||
| if (not block_hash_res) { |
There was a problem hiding this comment.
if !previous_last_finalized_block && last_finalized_block != 0 -> current_block_number = 0
цикл начнется с (uint64_t)(-1), что сильно больше last_finalized_block, и блоки будут не учтены
There was a problem hiding this comment.
Fixed, initialized with 1
Comment on lines
3402
to
3404
| new int, [this, &block_hash](void *) { | ||
| state_by_relay_parent_to_check_.erase(block_hash); | ||
| }); |
There was a problem hiding this comment.
(void*)1, в текущем варианте тут утекает память
There was a problem hiding this comment.
Unfortunately had to go back to scope guard in the end because of clang-tidy errors.
Comment on lines
3529
to
3531
| std::vector<uint8_t> buffer(extrinsic.data.begin() + 3, | ||
| extrinsic.data.end()); | ||
| auto decode_res = scale::decode<parachain::ParachainInherentData>(buffer); |
ErakhtinB
force-pushed
the
feature/missing_votes_metric
branch
from
e6f57d6 to
a9c47fb
Compare
kamilsa
approved these changes
Mar 26, 2025
|
Temporarily disabled auto merge until local checks passed |
|
Everything seems to work ok now, no need to hold the merge anymore |
iceseer
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: