Skip to content

propagate error from resource_allocation_info #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

antgonza
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 10, 2025

Coverage Status

coverage: 92.365% (-0.01%) from 92.376%
when pulling 734d414 on antgonza:raise-error-resource-alloc
into d0e03de on qiita-spots:dev.

Copy link
Contributor

@AmandaBirmingham AmandaBirmingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @antgonza -- If I am reading this right, the code here calls resource_params = self.resource_allocation_info twice, once on line 1052 outside the try, and once on line 1053 inside the try. Is this intentional? I can't figure out how it does what we want.

@antgonza
Copy link
Member Author

Good catch, thank you; forgot to remove the line above.

@AmandaBirmingham AmandaBirmingham merged commit 077df38 into qiita-spots:dev Apr 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants