Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemmy Support #169

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Lemmy Support #169

wants to merge 9 commits into from

Conversation

chaorace
Copy link

@chaorace chaorace commented Jul 2, 2023

This PR introduces support for running holo against Lemmy communities. The Lemmy backend is mostly at parity with the original reddit backend except for flair support, which I believe Lemmy currently has no equivalent for.

I'm submitting this PR as a draft to start with because it's only been lightly tested and is kind of a hackjob at that (I'm not all that familiar with Python...). Absent any design feedback requiring additional work, my plan is to do about a week of real-world testing & refinement before taking it out of draft status. This timeline may vary depending on how long it takes me to find a community willing to be my guinea pigs -- I am currently petitioning the anime@lemmy.ml community moderators for permission

@chaorace
Copy link
Author

chaorace commented Jul 3, 2023

I did a little private testing, so here's some basic evidence to share showing that the code ostensibly does what it's supposed to do: https://lemmy.world/post/967915

@chaorace
Copy link
Author

chaorace commented Jul 5, 2023

Hmm... as of now I'm stalled out on trying to find any Lemmy communities willing to test this bot.

Anyone interested in having their community participate should ping me. For now I guess this PR's just going to linger as a draft until I myself find enough free time to drum up a test environment & server from scratch 🤷

@chaorace
Copy link
Author

Good news! The bot is now live on !anime@lemmy.ml. @ajstamps has been collaborating with me to get things spun up and I believe they'll be committing some further polish to this fork as we continue to monitor and tweak the bot over the next few days 🤞

This helper function doesn't talk to the instance, so no need to invoke
_ensure_connection here.
Whatever baked-in interpolation the logging library has seems to break
under weird cases that I can't really figure out how to grok. We have
fstrings now anyway so I just switched to using those instead of trying
to think too hard about it...
I just realized that lemmy.ml doesn't allow new user signups, so in
order to make this bot work with lemmy.ml I needed to add support for
bot accounts which belong to a different instance from the main community
@@ -4,13 +4,21 @@ database = database.sqlite
[connection]
useragent =

# Reddit backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Reddit backend

Just commenting, but I don't think this line is needed, because of the [reddit] directly below it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants