db2: Fix exception during temp table lookup #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #905 |
simonpcouch
approved these changes
Apr 7, 2025
| @@ -68,7 +68,9 @@ setMethod("odbcConnectionTables", c("DB2/AIX64", "character"), | |||
| tryCatch({ | |||
| dfTempTables <- dbGetQuery(conn, query) | |||
| # NULL as colname is not well liked by DB2 it seems. Hack here. | |||
There was a problem hiding this comment.
Suggested change
| # NULL as colname is not well liked by DB2 it seems. Hack here. | |
| # NULL as colname is not well liked by DB2 it seems. Hack here. (#905). |
This will provide a clickable link in RStudio/Positron, making for easier navigation to the relevant GitHub archaelogy.
| @@ -68,7 +68,9 @@ setMethod("odbcConnectionTables", c("DB2/AIX64", "character"), | |||
| tryCatch({ | |||
| dfTempTables <- dbGetQuery(conn, query) | |||
| # NULL as colname is not well liked by DB2 it seems. Hack here. | |||
| dfTempTables$table_remarks <- NA_character_ | |||
| if (nrow(dfTempTables)) { | |||
There was a problem hiding this comment.
Suggested change
| if (nrow(dfTempTables)) { | |
| if (nrow(dfTempTables) > 0) { |
I admit that we don't apply this consistently throughout the repo, but I tend to prefer not leaning on the "positive number evaluates to TRUE" in if statements" trick, and this seems to be the norm in the tidyverse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self explanatory.