-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add a Contributing Guide #102
base: branch-25.04
Are you sure you want to change the base?
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I have a few optional suggestions.
|
||
--> | ||
|
||
### Summary of pre-commit hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion, but it might be better in the long run to just mention the yaml file that contains the checks (which you did) and remove the more detailed descriptions of each check, since it seems likely to go stale. I think the most important things contributors should know was already mentioned: how to install and run pre-check, and where the list of checks are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea. Less things to maintain is good. Pushed the change.
Co-authored-by: Rick Ratzel <3039903+rlratzel@users.noreply.github.com>
Closes #103
Proposed Change
Adds a
CONTRIBUTING.md
file to the repo. This should cover opening issues, contributing to the project, setting up development environments, pre-commit hooks, and RAPIDS conventions.