Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add a Contributing Guide #102

Open
wants to merge 7 commits into
base: branch-25.04
Choose a base branch
from

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Mar 18, 2025

Closes #103

Proposed Change

Adds a CONTRIBUTING.md file to the repo. This should cover opening issues, contributing to the project, setting up development environments, pre-commit hooks, and RAPIDS conventions.

@nv-rliu nv-rliu requested a review from a team as a code owner March 18, 2025 21:02
@nv-rliu nv-rliu requested review from eriknw and rlratzel March 18, 2025 21:03
@nv-rliu nv-rliu added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Mar 18, 2025
@nv-rliu nv-rliu marked this pull request as draft March 18, 2025 21:06
Copy link

copy-pr-bot bot commented Mar 18, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@nv-rliu nv-rliu marked this pull request as ready for review March 19, 2025 21:40
@nv-rliu nv-rliu changed the title Add CONTRIBUTING Guide Doc [DOC] Add a Contributing Guide Mar 19, 2025
@rlratzel rlratzel added this to the 25.04 milestone Mar 26, 2025
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I have a few optional suggestions.


-->

### Summary of pre-commit hooks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion, but it might be better in the long run to just mention the yaml file that contains the checks (which you did) and remove the more detailed descriptions of each check, since it seems likely to go stale. I think the most important things contributors should know was already mentioned: how to install and run pre-check, and where the list of checks are.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea. Less things to maintain is good. Pushed the change.

nv-rliu and others added 2 commits March 26, 2025 19:57
Co-authored-by: Rick Ratzel <3039903+rlratzel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]: Add CONTRIBUTING Guide
2 participants