Skip to content

fix: *sklearn* version compability in stacking_cv params #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

d-kleine
Copy link
Contributor

@d-kleine d-kleine commented Apr 6, 2025

Description

Enhances compatibility with scikit-learn versions 1.4 and above by adjusting parameter handling in the stacking_cv functions (classification, regression)

tests:
pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
pytest ./mlxtend/regressor/tests/test_stacking_cv_regression.py -sv

Related issues or pull requests

fixes #1117

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@d-kleine d-kleine marked this pull request as ready for review April 6, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: got an unexpected keyword argument 'fit_params'
1 participant