Skip to content

Play: some improvements towards sourcemaps. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Play: some improvements towards sourcemaps. #25

merged 4 commits into from
Aug 6, 2024

Conversation

gunsch
Copy link
Collaborator

@gunsch gunsch commented Jul 10, 2024

💸 TL;DR

A couple steps on the journey of using sourcemaps effectively within Play.

  • Extracts inline sourcemaps to stick onto the LinkedBundle
  • Drops an unnecessary newline, that was creating off-by-one errors when using debugger; statements (and would have similar impact for stack traces).

The rest of the code for actually making use of the sourcemap looks like it'll end up within runtime-lite.

@gunsch gunsch requested a review from niedzielski July 10, 2024 22:02
@gunsch gunsch marked this pull request as ready for review July 10, 2024 22:02
@gunsch gunsch merged commit e5b6674 into main Aug 6, 2024
1 check passed
@gunsch gunsch deleted the sourcemaps branch August 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants