test "throw away double dash" and also fix pass_through generally #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbs
force-pushed
the
double-dash-test
branch
from
d0bdd16 to
5fbc027
Compare
Imagine this invocation: appname cmdname -a one -- -z two Common sense (I think) would lead us to believe that when the "execute" method on the command class for "cmdname" is called, $args would contain: [ '-z', 'two' ] ...but in reality, we get the leading `--`. That's really just meant to be an instruction to Getopt::Long, and not an argv token. This commit adds a test for this case. It also sets _getopt_conf in Test::MyCmd to [] because without that, unknown tokens are passed along, including the `--`.
When interpreting:
appname [ cmdname --xyz ]
^- ARG0 ^- ARGV
Getopt::Long is run against the ARGV twice: once to pluck out global
options and command name from the start, once to process the options to
that command.
The first pass must *always* be called with $Getopt::Long::pass_through
set, because that's how "cmdname" is left in place. Because the
arguments to Getopt::Long::Configure are an ordered list of
instructions, we can just tack "pass_through" on to the end, even if it
was already in the defaults, or follows a "no_pass_through".
This change will require Getopt::Long::Descriptive 0.116, because
previous versions do not localize their changes to Getopt::Long
configuration.
rjbs
force-pushed
the
double-dash-test
branch
from
5fbc027 to
a86360e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.