Implement myIpAddressEx()

[samuong]

No description provided.

[camh-]

LGTM. Just some little nitpicks suggestions.

[camh-]

for i, ip := range ips {
    if i > 0 {
        b.WriteRune(';')
    }

It's pretty simple to not put the leading ; on in the first place, removing the need to strip it off again.

[samuong]

Ok, my original thinking was that trimming the leading ; would save having to do the check inside the loop. But I'll do it this way so that people reading it don't think it's a bug, at least initially.

[camh-]

An alternative trim would be to just slice off the first byte instead of using TrimPrefix() - a semicolon is always a single byte so you don't need to worry about variable length runes or anything - so just b.String()[1:].

I only mentioned it because of a moment of "huh?" before it clicked, but the i > 0 is a pretty obvious/common pattern to me.

Hmmm now I notice that you check for len(ips) > 0, how about:

b.WriteString(ips[0].String())
for _, ip := range ips[1:] {
    b.WriteRune(';')
    b.WriteString(ip.String)
}

It's mostly just nitpickery, but who has time to code-golf a whole program!

[samuong]

I used strings.TrimPrefix() because it handles the len(ips) == 0 case, but as you've pointed out that's never going to happen 🤦

[camh-]

If the order of the output does not need to match the order of the input, you don't really need the slice and you could simplify this:

    set := map[string]struct{}{}
    for _, address := range addresses {
        if localAddr := probeRoute(address); localAddr != "" {
            set[localAddr] = struct{}{}
        }
    }
    return strings.Join(slices.Collect(maps.Keys(set)), ";")

This does need Go 1.23 for slices.Collect() and maps.Keys() though.

[samuong]

I was still on 1.22 but yes this would be nicer. I still need to check but I'll do it this way if I can confirm that order isn't important.

[samuong]

I haven't found out whether order is important or not, but I think I'll just leave this as is, just in case it is.