Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes up to commit f35d4637 #415

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

illia-li
Copy link

@illia-li illia-li commented Apr 7, 2025

Original commit list:
1. apache@f3d13d4
Message:

Add support for cassandra 4.0 table options
In the PR implemented backward compatibility with previous versions,
and added new types support. To make metadata table support easier for
future Cassandra versions, hardcode scan from Cassandra were replaced
with new "parseSystemSchemaViews" method which is much easier to expand,
even if some fields were added in the middle of the table it wouldn`t be an issue anymore.

patch by Mykyta Oleksiienko; reviewed by Joao Reis and James Harting CASSGO-13

Status: APPLIED

2. apache@65e2caf
Message:

Refactor HostInfo creation and ConnectAddress() method
HostInfo struct creation was refactored to create via constructor to make sure the connectAddress is valid.
Panic in case of invalid connect address inside of ConnectAddress() method was removed.

patch by Oleksandr Luzhniy; reviewed by João Reis, James Hartig, for CASSGO-45

Status: APPLIED

3. apache@f35d463
Message:

Move the lz4 compressor into a separate go package
Currently, the LZ4 compressor is maintained as a separate module under gocql/lz4.
However, its implementation is tightly coupled with Cassandra's specific requirements.
To streamline development, reduce dependency management complexity,
and better encapsulate Cassandra-specific logic,
the lz4 compressor has been moved to a lz4 package within the main gocql module.

Patch by Mykyta Oleksiienko; reviewed by Joao Reis, Bohdan Siryk, Stanislav Bychkov and James Hartig for CASSGO-32

Status: APPLIED

OleksiienkoMykyta and others added 4 commits February 5, 2025 15:12
In the PR implemented backward compatibility with previous versions,
and added new types support. To make metadata table support easier for
future Cassandra versions, hardcode scan from Cassandra were replaced
with new "parseSystemSchemaViews" method which is much easier to expand,
even if some fields were added in the middle of the table it wouldn`t be an issue anymore.

patch by Mykyta Oleksiienko; reviewed by Joao Reis and James Harting CASSGO-13
HostInfo struct creation was refactored to create via constructor to make sure the connectAddress is valid.
Panic in case of invalid connect address inside of ConnectAddress() method was removed.

patch by Oleksandr Luzhniy; reviewed by João Reis, James Hartig, for CASSGO-45
Currently, the LZ4 compressor is maintained as a separate module under gocql/lz4.
However, its implementation is tightly coupled with Cassandra's specific requirements.
To streamline development, reduce dependency management complexity,
and better encapsulate Cassandra-specific logic,
the lz4 compressor has been moved to a lz4 package within the main gocql module.

Patch by Mykyta Oleksiienko; reviewed by Joao Reis, Bohdan Siryk, Stanislav Bychkov and James Hartig for CASSGO-32
@dkropachev dkropachev self-assigned this Apr 7, 2025
@dkropachev dkropachev merged commit 200d35b into scylladb:master Apr 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants