-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Replace libgit2 with gitoxide #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for working on this! Honestly, it feels like the diffs are still valid, so adapting the tests is acceptable in my opinion. However you might find that extending the |
You may also find this document about diff-sliders interesting. It also details the tuning that Git has received to produce more 'likable' diffs, some of which Right now, As this comes up all the time, I also feel that pressure is mounting, and more so the more people use |
I think that trying to improve |
The diffing library that gitoxide uses does not have the same optimizations as libgit2 (yet)
Since I have not been able to work much on the |
As discussed in #3151, I have prepared a PR to replace the
libgit2
usage inbat
withgitoxide
. The PR is not finished yet because some tests are failing since the producedgit diff
does not match the exact behavior oflibgit2
.I see here two solutions:
imara-diff
crate to generategit
like diffsWhat do the maintainers think?
CC: @Byron