Change grpc_prometheus dependency source #1968
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
prometheus
branch
from
0ef7d11 to
c83a719
Compare
loosebazooka
force-pushed
the
prometheus
branch
2 times, most recently
from
01363b6 to
971ed1c
Compare
Old source has been deprecated and we're expected to pull the dependency from go-grpc-middleware now Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
prometheus
branch
from
971ed1c to
dbc2884
Compare
|
Things I've discovered:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old source has been deprecated and we're expected to pull the dependency from go-grpc-middleware now
Summary
See: https://github.com/grpc-ecosystem/go-grpc-prometheus?tab=readme-ov-file#deprecated-go-grpc-interceptors-for-prometheus-monitoring
Added some labels since we have a bunch of different kind of servers but I don't know if it actually adds anything.
Someone more familiar with prometheus is going to have to check me on a few things here.
Release Note
NONE
Documentation
NONE