Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote StepActions to GA #8546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: promote StepActions to GA #8546

wants to merge 1 commit into from

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Jan 31, 2025 •
edited
Loading

Changes

fixes #8485

enable using StepActions out of the box for tekton-pipelines by promoting it to GA

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

StepActions promoted to GA and is available by default. The enable-step-actions feature flag exists as a no-op flag to ensure that existing user workflows which might rely on this flag are not disabled. This flag will be removed completely in a later release.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 31, 2025
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2025
@tekton-robot tekton-robot requested review from abayer and jerop January 31, 2025 16:47
@waveywaves waveywaves marked this pull request as ready for review January 31, 2025 16:51
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@waveywaves
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 31, 2025
l-qing
l-qing reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@l-qing l-qing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any TEP documents or checklists to determine if the feature meets beta maturity?

@waveywaves
Copy link
Member Author

@l-qing the current tracker I am following is #8485

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from ed246ea to 405e8ed Compare February 12, 2025 18:58
@waveywaves
Copy link
Member Author

cc @vdemeester

@tekton-robot
Copy link
Collaborator

@waveywaves: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests 405e8ed link true /test pull-tekton-pipeline-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch 2 times, most recently from 95ffb3a to 845dd31 Compare February 19, 2025 21:59
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 845dd31 to a45de74 Compare February 19, 2025 22:04
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from a45de74 to d4a5306 Compare February 19, 2025 22:05
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from d4a5306 to 3fa0ffa Compare February 19, 2025 22:34
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 5453842 to 990acf4 Compare March 28, 2025 17:42
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 990acf4 to a552226 Compare March 28, 2025 17:55
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch 3 times, most recently from f8e1b35 to c35c56d Compare March 28, 2025 19:08
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from c35c56d to 303541f Compare March 28, 2025 20:15
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 303541f to e2e4108 Compare March 28, 2025 21:11
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@waveywaves
Copy link
Member Author

@vdemeester I have added a no-op for the step actions flag
@afrittoli I have made sure that step actions is available by default now

@vdemeester
Copy link
Member

Looks good to me 🎉
/cc @afrittoli @chitrangpatel @abayer

afrittoli
afrittoli reviewed Apr 1, 2025
View reviewed changes
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from e2e4108 to 2b644b3 Compare April 1, 2025 18:39
@waveywaves
feat: promote StepActions to GA
236035d 
Upgrade StepActions feature from beta to stable to make sure that it is enabled by default.
StepActions has been in beta for a while and is also has good adoption among the community.
It is pretty stable as a feature based on the regular usage. Moving it to GA will make sure
that users will have access to better pipeline composability from the get-go.
The following changes were made:
- set enable-step-actions to "true" by default
- updated to reflect that StepActions are now enabled by default
- changed the feature flag stability from BetaAPIFields to StableAPIFields in feature_flags.go
- updated feature flags, e2e tests and test data
- moved relevant examples to stable examples
- added relevant documentation for the move from beta to stable
- make enable-step-actions into no-op feature flag.

This change makes StepActions a stable, first-class feature in Tekton Pipelines.
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 2b644b3 to 236035d Compare April 1, 2025 18:45
@waveywaves
Copy link
Member Author

@afrittoli thank you for the review ! updated the commit based on your comments, lmkwyt

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 94.9% 94.8% -0.1
pkg/apis/pipeline/v1/task_validation.go 98.6% 94.3% -4.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.6% 94.1% -4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli afrittoli left review comments

@l-qing l-qing l-qing approved these changes

@jerop jerop jerop approved these changes

@abayer abayer Awaiting requested review from abayer

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: In Progress
Milestone
Pipeline v1.0.0
Development

Successfully merging this pull request may close these issues.

TEP-0142 Promote StepActions to GA
6 participants
@waveywaves @tekton-robot @vdemeester @afrittoli @l-qing @jerop