Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: override task timeouts in pipelineruns #8636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: override task timeouts in pipelineruns #8636

wants to merge 1 commit into from

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Mar 11, 2025 •
edited
Loading

Changes

/fixes #7752

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025
@waveywaves
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.8% -0.9

@waveywaves waveywaves force-pushed the override-task-timeout branch from 41cbb8b to 1cb87f9 Compare March 11, 2025 15:12
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.8% -0.9

@waveywaves waveywaves force-pushed the override-task-timeout branch from 1cb87f9 to d5ca69c Compare March 28, 2025 23:47
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.8% -0.9

@waveywaves waveywaves force-pushed the override-task-timeout branch from d5ca69c to 0418ce7 Compare March 29, 2025 00:20
@waveywaves waveywaves closed this Mar 29, 2025
@waveywaves waveywaves force-pushed the override-task-timeout branch from 0418ce7 to 5b082b1 Compare March 29, 2025 00:27
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2025
@waveywaves waveywaves reopened this Mar 29, 2025
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2025
@waveywaves waveywaves marked this pull request as ready for review March 29, 2025 00:31
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2025
@tekton-robot tekton-robot requested a review from pritidesai March 29, 2025 00:31
@waveywaves waveywaves force-pushed the override-task-timeout branch from 38db1f0 to 440d481 Compare March 29, 2025 00:45
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

@waveywaves waveywaves force-pushed the override-task-timeout branch 2 times, most recently from 9c66620 to ee773fc Compare March 31, 2025 19:52
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

@waveywaves waveywaves force-pushed the override-task-timeout branch from ee773fc to c19714c Compare March 31, 2025 20:06
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

@waveywaves
Copy link
Member Author

cc @vdemeester @afrittoli @aThorp96 ready for review

vdemeester
vdemeester approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tektoncd/core-maintainers @afrittoli

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to override the timeout value for individual pipeline tasks via taskRunSpecs in a pipelineRun
3 participants
@waveywaves @tekton-robot @vdemeester