connector:issue deprecates --database, --table and --time-column options #114
Conversation
now `--database` and `--table` is obsolete
muga
changed the title
|
Discussion at #67 includes an idea to include database and table names in @muga Do you think it's better to set db and table names at cmdline argument? |
| @@ -345,7 +345,7 @@ def self.finishup | |||
| add_list 'connector:guess', %w[config?], 'Run guess to generate connector config file', ["connector:guess config.yml -o td-bulkload.yml\n\nexample config.yml:#{connector_guess_example_config}"] | |||
| add_list 'connector:preview', %w[config], 'Show preview of connector execution', ['connector:preview td-bulkload.yml'] | |||
|
|
|||
| add_list 'connector:issue', %w[config], 'Run one time connector execution', ['connector:issue td-bulkload.yml'] | |||
| add_list 'connector:issue', %w[config database table], 'Run one time connector execution', ['connector:issue example_db event_logs td-bulkload.yml'] | |||
There was a problem hiding this comment.
This change is not backward compatible. This makes existent automated shell scripts failed which are using --database and --table options.
There was a problem hiding this comment.
Sorry. I'll fix it.
|
I fixed following items.
|
|
Thank you for your working:-) The fix requires platform side change. Please talk about it later. |
Because, we recommend to write to config file these options.
|
I removed argument option(database, table) . Because, these options should write to configuration file. |
now
--databaseand--tableis obsoleteref #67