-
Notifications
You must be signed in to change notification settings - Fork 329
NAS-135214 / 25.10 / Improvements for new user form #11868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11868 +/- ##
==========================================
- Coverage 83.63% 83.56% -0.07%
==========================================
Files 1677 1677
Lines 59537 59565 +28
Branches 6571 6574 +3
==========================================
- Hits 49795 49778 -17
- Misses 9742 9787 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There are upcoming changes for user data storage. Please sync with @RehanY147 on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new page looks good. The old one still has experimental features.
sorry, did I miss something, which new features are there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
This PR has been merged and conversations have been locked. |
Testing: see ticket.
Edit user -> opens old form since new form is not adapted for that logic.
Known issues described in the separate ticket, and will be fixed there --> https://ixsystems.atlassian.net/browse/NAS-135258