Skip to content

NAS-135214 / 25.10 / Improvements for new user form #11868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Apr 9, 2025

Testing: see ticket.
Edit user -> opens old form since new form is not adapted for that logic.

Known issues described in the separate ticket, and will be fixed there --> https://ixsystems.atlassian.net/browse/NAS-135258

  1. Save button is not disabled if form is invalid.
  2. User list is not updated & newly create User is not selected once new user is created.

@AlexKarpov98 AlexKarpov98 self-assigned this Apr 9, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner April 9, 2025 11:24
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team April 9, 2025 11:24
@bugclerk bugclerk changed the title NAS-135214: Improvements for new user form NAS-135214 / 25.10 / Improvements for new user form Apr 9, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Apr 9, 2025

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (b38761f) to head (ea7519d).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ers/all-users-header/all-users-header.component.ts 75.00% 2 Missing ⚠️
...ponents/ix-user-picker/ix-user-picker.component.ts 50.00% 1 Missing ⚠️
...delete-user-dialog/delete-user-dialog.component.ts 50.00% 1 Missing ⚠️
...credentials/users/user-list/user-list.component.ts 66.66% 1 Missing ⚠️
src/app/pages/credentials/users/user.routes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11868      +/-   ##
==========================================
- Coverage   83.63%   83.56%   -0.07%     
==========================================
  Files        1677     1677              
  Lines       59537    59565      +28     
  Branches     6571     6574       +3     
==========================================
- Hits        49795    49778      -17     
- Misses       9742     9787      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@denysbutenko
Copy link
Member

  1. User list is not updated & newly create User is not selected once new user is created.

There are upcoming changes for user data storage. Please sync with @RehanY147 on it.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new page looks good. The old one still has experimental features.

@AlexKarpov98
Copy link
Contributor Author

The new page looks good. The old one still has experimental features.

sorry, did I miss something, which new features are there?

@denysbutenko
Copy link
Member

The new page looks good. The old one still has experimental features.

sorry, did I miss something, which new features are there?

image

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@AlexKarpov98 AlexKarpov98 merged commit 2dee6a0 into master Apr 10, 2025
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-135214 branch April 10, 2025 06:53
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants