Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized 5 different buffers. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahzadlone
Copy link

Many vectors weren't being reserved where we already know the size.

This makes the vector re-allocate(expensive) more times than necessary.

I reserved the 5 vectors where we already knew how many elements will get pushed in.

I also reduced the scope of audio_samples,video_samples,edit_boxes because they were declared way earlier than they are actually used. (prefer to delay declaration, as much as possible.)

Also made edit_box a constant and a reference to save a copy cost and const because it isn't changed.

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2019

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants