Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many vectors weren't being reserved where we already know the size.
This makes the vector re-allocate(expensive) more times than necessary.
I reserved the 5 vectors where we already knew how many elements will get pushed in.
I also reduced the scope of
audio_samples
,video_samples
,edit_boxes
because they were declared way earlier than they are actually used. (prefer to delay declaration, as much as possible.)Also made
edit_box
a constant and a reference to save a copy cost andconst
because it isn't changed.