LIBAAEC-48 WIP Libaaec 48 fix broken feature tests due to chrome update #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage, and Ruby setup
…d-fix-bundler-audit-issues-to-allow-p-rs-to-move-forward' into LIBAAEC-46-run-db-seed-with-deployments
…measurement' into LIBAAEC-46-run-db-seed-with-deployments
…i-to-github-actions-to-handle-ci' into LIBAAEC-46-run-db-seed-with-deployments
…eature-tests-due-to-chrome-update
github-actions
bot
changed the title
Switch to the documentation formatter in CI so that test results are printed in detail to the workflow log while still saving the XML report.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: LIBAAEC-48
This PR improves the reliability and consistency of our feature tests by addressing timing issues, refining selectors, and switching the browser driver from Chrome to Firefox.
Changes
Extended Wait Times:
Increased the Capybara default wait time to 1 minute to better accommodate asynchronous operations and slow redirects.
Retry Logic:
Added retries for stubborn operations, such as clicking buttons and waiting for redirects, to reduce test flakiness.
Authenticity Token Selector:
Updated the helper method for invalidating authenticity tokens to target the hidden input within the form more specifically.
Browser Update:
Switched test execution from Chrome to Firefox to align with our target environment and improve compatibility.
Impact
Tests now wait longer for dynamic content, reducing intermittent failures.
More robust selectors and retry logic help ensure that operations like button clicks and redirects execute reliably.
The refined handling of authenticity tokens ensures that our CSRF protection tests work as intended.