Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request review fixes 0.23 #724

Merged
merged 9 commits into from
Feb 10, 2021
Merged

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented Feb 9, 2021

Proposed changes

Implemented a few more suggestions from the pullrequest.com review
#639

We are down to just 40 remaining suggestions 🎉

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #724 (b38d69b) into develop (c59f9ad) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #724      +/-   ##
===========================================
- Coverage    96.33%   96.33%   -0.01%     
===========================================
  Files           69       69              
  Lines         4453     4452       -1     
===========================================
- Hits          4290     4289       -1     
  Misses         163      163              
Impacted Files Coverage Δ
paramak/neutronics_utils.py 92.85% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59f9ad...b38d69b. Read the comment docs.

@shimwell shimwell merged commit d551a90 into develop Feb 10, 2021
@shimwell shimwell deleted the pull_request_review_fixes_0.23 branch February 10, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants