Update era codes #6405
Update era codes #6405
Conversation
There was a problem hiding this comment.
The latest proposal already differs from what is in this PR, and I'm not currently of the opinion that we should be on the vanguard here before CLDR adopts them. Nothing has been approved by anyone yet. I think keeping the test is more valuable at this instant in time. This might be different in 5-10 days from now but I don't know at this moment in time
I'm not convinced that future changes will be smaller and incremental. We're already likely backtracking on some of my proposed changes to Minguo and Coptic. |
|
While what's currently on main aligns with what's currently in CLDR (#6248, #6252), it is sufficiently in flux that I don't want to release the current code. If we release 2.0 with calendars that return eras like What's currently proposed in CLDR, and what this PR implements, is a much smaller diff to the 1.5 behaviour. |
| @@ -504,25 +504,26 @@ fn test_calendar_eras() { | |||
| let in_era = in_era_iso.to_calendar(cal); | |||
| let not_in_era = not_in_era_iso.to_calendar(cal); | |||
|
|
|||
| // TODO: reenable with CLDR-48 | |||
unicode-org/cldr#4519