RSDK-10257 - Early return if tunnel destination port not allowed #4856
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
cheukt
commented
Mar 14, 2025
| @@ -1368,6 +1368,21 @@ func RobotsPartTunnelAction(c *cli.Context, args robotsPartTunnelArgs) error { | |||
| } | |||
|
|
|||
| func tunnelTraffic(ctx *cli.Context, robotClient *client.RobotClient, local, dest int) error { | |||
| // don't block tunnel attempt if ListTunnels fails in any way - it may be unimplemented. | |||
| // TODO: early return if ListTunnels fails. | |||
There was a problem hiding this comment.
You don't want to this in actual robotClient.Tunnel? That way both the CLI and anyone trying to programmatically use robotClient.Tunnel both encounter early errors?
There was a problem hiding this comment.
issue is robotClient.Tunnel isn't called until the first connection is made. if robotClient.Tunnel is called, it'd error out immediately even without this change
There was a problem hiding this comment.
Ah gotcha thanks for the explanation 🙏🏻 .
viambot
added
safe to test
benjirewis
approved these changes
Mar 14, 2025
cli/client.go
Outdated
| } | ||
| } | ||
| if !allowed { | ||
| return errors.Errorf("tunneling to destination port %v not allowed", dest) |
There was a problem hiding this comment.
Could add a small message about ensuring traffic_tunnel_endpoints is set correctly on your machine.
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe merge next week to allow for the rollout of config changes first.
example output