Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-7845] Change default log time filter to 1 day #4857

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JosephBorodach
Copy link
Member

@JosephBorodach JosephBorodach commented Mar 14, 2025

Description

Update the CLI and API to match the UI change by setting the default log time filter to 1 day instead of 30 days.

See ticket here

Todo

  • Manually test the cli

Manual Tests

The the updated default message for start time

go run cli/viam/main.go machines logs 

Screenshot 2025-03-14 at 1 15 15 PM

This machine does not have any logs within the last 12 hours, so none should be returned

go run cli/viam/main.go machines logs -machine="plant-1" --organization="Joseph's Org" --location="plant-waterer"

Screenshot 2025-03-14 at 1 18 33 PM

Request for logs from 30 days ago

go run cli/viam/main.go machines logs -machine="plant-1" --organization="Joseph's Org" --location="plant-waterer" --start="2025-02-14T21:30:00Z"

Screenshot 2025-03-14 at 1 20 26 PM

@JosephBorodach JosephBorodach requested a review from a team as a code owner March 14, 2025 17:09
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 14, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 14, 2025
@JosephBorodach JosephBorodach force-pushed the APP-7845-Change-Default-Log-Time-Filter-to-Twelve-Hours branch from 09166dc to 9a48570 Compare March 14, 2025 17:33
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 14, 2025
@JosephBorodach JosephBorodach changed the title [APP-7845] Change default log time filter to twelve hours [APP-7845] Change default log time filter to 1 day Mar 14, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants