Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: add missing check for IfExpr and MatchExpr with no valid type #23832

Merged
merged 5 commits into from
Mar 1, 2025
Merged

checker: add missing check for IfExpr and MatchExpr with no valid type #23832

merged 5 commits into from
Mar 1, 2025

Conversation

felipensp
Copy link
Member

Fix current crash when using:

fn main() {
	a := if true { none } else { none }
}

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-22237

@felipensp felipensp changed the title checker: add missing check for IfExpr with no valid type checker: add missing check for IfExpr and MatchExpr with no valid type Feb 28, 2025
@felipensp felipensp marked this pull request as ready for review March 1, 2025 00:20
spytheman
spytheman approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@medvednikov medvednikov merged commit 2cd1f6e into vlang:master Mar 1, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JalonSolov JalonSolov JalonSolov left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felipensp @spytheman @JalonSolov @medvednikov