Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto.ecdsa: the last bits of migration steps #23877

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

blackshirt
Copy link
Contributor

@blackshirt blackshirt commented Mar 8, 2025

This follow-up PR from the last commited pr. In this PR, its done by migrating the last bits required to be changed, ie .bytes() method on the PrivateKey and PublicKey.
Its was done by using high level function. All info's of EVP_PKEY opaque was already availables on both of them by previous migrations. This series contains the bits forms:

  • The changes on .bytes() on the both of PrivateKey and PublicKey
  • Adds required definitions
  • Some fixs of private and public key loader

After this PR, we can start out to cleanup some deprecated code. Should be this cleanup phase done in gradually step ?

Copy link

Connected to Huly®: V_0.6-22280

@JalonSolov
Copy link
Contributor

V "policy" is to add @[deprecated] attributes, and set a date for 6 months in the future before the deprecation warning turns into an error.

@blackshirt
Copy link
Contributor Author

blackshirt commented Mar 8, 2025

V "policy" is to add @[deprecated] attributes, and set a date for 6 months in the future before the deprecation warning turns into an error

Actually, this series was not about deprecation, .. I think its can be done in the last step after cleans up with the reasons,
The mean with deprecated code was mostly for deprecated EC_KEY functions

@spytheman
Copy link
Member

spytheman commented Mar 8, 2025

Deprecating public APIs and declarations takes time (to give the users time to update their own code).

Code that is not public, can be just deleted, when it is no longer used.

@spytheman spytheman merged commit ec0b70e into vlang:master Mar 8, 2025
69 of 70 checks passed
@blackshirt blackshirt deleted the migrate_bytes_fn branch March 9, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants